Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to GitHub actions for E2E tests #569

Merged
merged 3 commits into from
Oct 8, 2023
Merged

Switch to GitHub actions for E2E tests #569

merged 3 commits into from
Oct 8, 2023

Conversation

stevesoltys
Copy link
Member

@stevesoltys stevesoltys commented Sep 26, 2023 •
edited
Loading

No description provided.

@stevesoltys stevesoltys force-pushed the feature/e2e-github-actions branch 3 times, most recently from 153b11a to a3b8b1b Compare September 28, 2023 06:02
@stevesoltys stevesoltys force-pushed the feature/e2e-github-actions branch 2 times, most recently from 40b736b to a889061 Compare October 7, 2023 18:51
@stevesoltys stevesoltys changed the base branch from android13 to staging/android14 October 7, 2023 18:51
@chirayudesai chirayudesai force-pushed the staging/android14 branch 4 times, most recently from a607135 to 3e7f6ed Compare October 7, 2023 19:16
chirayudesai
chirayudesai previously approved these changes Oct 7, 2023
View reviewed changes
Copy link
Member

@chirayudesai chirayudesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, but I like, will be really nice to have it all be integrated.

.github/workflows/test.yml
strategy:
fail-fast: false
matrix:
android_target: [33, 34]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of testing for 13 in the 14 branch, to make sure any changes we make here don't break stuff / are backwards compatible. As much as possible, at least. We'll try.

app/build.gradle Show resolved Hide resolved
@chirayudesai
Copy link
Member

We could just merge this to android14 directly. It'd fail right now, but then #576 should pass.

@stevesoltys stevesoltys force-pushed the feature/e2e-github-actions branch 2 times, most recently from 4ff0fb3 to aabae58 Compare October 8, 2023 18:17
@chirayudesai chirayudesai changed the base branch from staging/android14 to android14 October 8, 2023 18:21
@chirayudesai chirayudesai dismissed their stale review October 8, 2023 18:21

The base branch was changed.

@chirayudesai chirayudesai merged commit 3938549 into android14 Oct 8, 2023
5 checks passed
@stevesoltys stevesoltys mentioned this pull request Oct 8, 2023
Closed
@stevesoltys stevesoltys deleted the feature/e2e-github-actions branch October 8, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirayudesai chirayudesai chirayudesai approved these changes

@grote grote Awaiting requested review from grote

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevesoltys @chirayudesai